Re: [PATCH 4/4] drm/i915: l3 parity sysfs interface

Ben Widawsky
2012-05-31T15:56:02Z

On Thu, 31 May 2012 12:45:56 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:

> On Fri, May 25, 2012 at 04:56:25PM -0700, Ben Widawsky wrote:
> > Dumb binary interfaces which allow root-only updates of the cache
> > remapping registers. As mentioned in a previous patch, software using
> > this interface needs to know about HW limits, and other programming
> > considerations as the kernel interface does no checking for these things
> > on the root-only interface.
> >
> > v1: Drop extra posting reads (Chris)
> > Return negative values in the sysfs interfaces on errors (Chris)
> >
> > v2: Return -EINVAL for offset % 4 (Jesse)
> > Move schizo userspace check out (Jesse)
> > Cleaner sysfs item initializers (Daniel)
> >
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
>
> I've queued this series for -next. Although you haven't fixed up the one
> issue in patch 2 I've noticed and I also don't see my bikeshed for this
> patch (despite that you claim to have done so). Whatever, I'll follow up
> with patches.
> -Daniel

Thanks for moving the patches forward, I'll review your fixes to them
shortly. The fixes are somewhere; I am not sure how they got lost.