From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: reuse the sdvo tv clock adjustment in ilk mode_set Date: Wed, 30 May 2012 13:56:01 +0100 Message-ID: <1338382593_357080@CP5-2952> References: <1338382346-16044-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id D91659E819 for ; Wed, 30 May 2012 05:56:37 -0700 (PDT) In-Reply-To: <1338382346-16044-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Wed, 30 May 2012 14:52:26 +0200, Daniel Vetter wrote: > Jesse extracted this nice helper in his i9xx_crtc_mode_set refactor, > but we have the identical code in ironlake_ccrtc_mode_set. And that > function is huge, so extracting some code full of magic numbers is > always nice. > > Noticed while trying to get a handle on our dp clock code. > > Signed-Off-by: Daniel Vetter Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre