Re: [PATCH] drm/i915: cache the EDID for eDP panels

Daniel Vetter
2012-06-06T07:21:53Z

On Tue, Jun 05, 2012 at 02:41:15PM -0700, Jesse Barnes wrote:
> On Tue, 05 Jun 2012 22:38:02 +0100
> Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> > On Tue, 5 Jun 2012 14:26:11 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > > Yeah that makes sense. Not sure how much this conflicts with Daniel's
> > > hot plug rework either; there's likely some overlap.
> >
> > We could have made that Daniel's problem.... ;)
> > http://lists.freedesktop.org/archives/intel-gfx/2011-April/010401.html
>
> Hey look I even reviewed it.
>
> Pick up the pieces, Daniel! :)

I agree looks nice. Can I ask for a resend? Afaics all the stuff got
acks/r-bs safe for patch 6 (maybe just drop that one). And I agree with
Jesse's bikeshed on patch 8, is_panel sounds more like what we want.

Dunno about patch 10, killing that pointless flicker would certainly be
nice. I guess we could just merge it and see what happens, then claim
innonce when getting caught with our hands in the cookie jar ;-)

Oh, and I don't think there's much overlap with the hpd stuff of mine,
that only caches edids at ->detect time and relies on core drm changes to
make calls to ->detect happen less often.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48