Re: [PATCH] drm/i915: cache the EDID for eDP panels

Daniel Vetter
2012-06-15T17:39:56Z

On Fri, Jun 15, 2012 at 10:31:06AM -0700, Jesse Barnes wrote:
> On Fri, 15 Jun 2012 10:34:22 +0300
> Jani Nikula <jani.nikula@linux.intel.com> wrote:
> > Hi Jesse, I'm sure you meant to do *something* with that return value. I
> > presume it should be equal to intel_dp->edid_mode_count, but is it
> > possible it's not? Is it better to return ret or
> > intel_dp->edid_mode_count from this function?
> >
>
> Heh there's always something... but yeah it should be equal to the
> mode_count; I should either drop the ret= or use it. Maybe as a
> cleanup on top since I'm tired of respinning this one? :p

I guess we can mend that bikeshed when we unify the panel handling some
more between lvds and eDP. Patch merged for -fixes, thanks.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48