From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: don't probe oui for eDP panels Date: Tue, 12 Jun 2012 11:34:09 +0100 Message-ID: <1339497254_10789@CP5-2952> References: <1339495367-24533-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 0235A9E9BB for ; Tue, 12 Jun 2012 03:34:24 -0700 (PDT) In-Reply-To: <1339495367-24533-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Tue, 12 Jun 2012 12:02:47 +0200, Daniel Vetter wrote: > At least not in the detect function. We'd need eDP vdd to do so if the > panel is off, but I've figured just disabling it is easier. > > This issue has been introduce in > > commit 0d198328538276c4459ef5de081e68ae60e6c4c2 > Author: Adam Jackson > Date: Mon May 14 16:05:47 2012 -0400 > > drm/i915/dp: Probe branch/sink OUIs > > Cc: Adam Jackson > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=50808 > Reported-by: Linus Torvalds > Bugreport: http://permalink.gmane.org/gmane.comp.video.dri.devel/69695 > Tested-by: Yang Guang > Signed-Off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/intel_dp.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index 296cfc2..34e1769 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -1970,6 +1970,9 @@ intel_dp_probe_oui(struct intel_dp *intel_dp) > { > u8 buf[3]; > > + if (is_edp(intel_dp)) > + return; Can I be annoying and ask this be annotated that we bail here for convenience and not due to lack of hw support? Otherwise we just add a moment of confusion should we ever need to log oui for eDP. (If manufacturers thought eDP -> LVDS dongles were a good idea, just imagine the chain in a couple of years time...) -Chris -- Chris Wilson, Intel Open Source Technology Centre