From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Switch off FBC when disabling the primary plane when obscured Date: Tue, 12 Jun 2012 21:30:22 +0100 Message-ID: <1339533031_13161@CP5-2952> References: <1339501560-31685-1-git-send-email-chris@chris-wilson.co.uk> <20120612072804.2ce5f1a8@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 46CE6A0253 for ; Tue, 12 Jun 2012 13:30:33 -0700 (PDT) In-Reply-To: <20120612072804.2ce5f1a8@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 12 Jun 2012 07:28:04 -0700, Jesse Barnes wrote: > Though now we have 3 "active" state variables for the crtc don't we? > active, enabled, and now primary_disabled? Oh and dpms state. I > really wish we could get rid of 2 or 3 of those... That crossed my mind as well. This felt like it was an orthogonal property of the crtc, though in reality if we disable the crtc we will disable the sprites as well so there is a dependence. Given how quickly the dream of reducing the number of active/enabled/disabled/dpms_mode states turns into a nightmare, I felt a certain reticient to attempting it. Perhaps our in-house dragon tamer may like to give it a shot? -Chris -- Chris Wilson, Intel Open Source Technology Centre