From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: add energy counter support for IVB Date: Wed, 20 Jun 2012 16:53:12 +0100 Message-ID: <1340207618_23753@CP5-2952> References: <20120619132050.6a423e71@jbarnes-desktop> <878vfiijwo.fsf@intel.com> <20120620073825.GB4835@phenom.ffwll.local> <20120620083259.28bf0518@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 959379E7D3 for ; Wed, 20 Jun 2012 08:53:43 -0700 (PDT) In-Reply-To: <20120620083259.28bf0518@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes , Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 20 Jun 2012 08:32:59 -0700, Jesse Barnes wrote: > On Wed, 20 Jun 2012 09:38:25 +0200 > Daniel Vetter wrote: > > And from the bikeshed departement: Can't we just print a running number? I > > know, substraction is bloody hard, but for anything else than total power > > consumption (e.g. graphing power over time) the running thing is imo > > simpler. We've had the same discussion for the rc6 sysfs residency timers > > and concluded (after Arjan yelled at us) that doing the substraction in > > userspace is better, least it allows multiple userspace tools to read > > this. > > > > Yeah that's a good point; this way happened to be simpler for what I > was doing, but just exposing the cooked register value (converted to > ujoules) is better. Will fix. And to keep it easy to parse, just make it return -ENODEV on older platforms and a simple number for gen6+. -Chris -- Chris Wilson, Intel Open Source Technology Centre