From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: prefer wide & slow to fast & narrow in DP configs Date: Fri, 22 Jun 2012 18:53:01 +0100 Message-ID: <1340387615_42474@CP5-2952> References: <1340316830-15601-1-git-send-email-jbarnes@virtuousgeek.org> <86pq8sqhcg.fsf@sumi.keithp.com> <1340355948_38587@CP5-2952> <86a9zvqm7t.fsf@sumi.keithp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id C16BF9E8B6 for ; Fri, 22 Jun 2012 10:53:41 -0700 (PDT) In-Reply-To: <86a9zvqm7t.fsf@sumi.keithp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Keith Packard , Jesse Barnes , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 22 Jun 2012 10:40:22 -0700, Keith Packard wrote: > Chris Wilson writes: > > > On Thu, 21 Jun 2012 18:13:19 -0700, Keith Packard wrote: > > > It was structured to minimise lane count because certain chipsets did > > not wire up all the lanes, right? Is that still relevant as we are using > > the advertised max_lane_count from the DPCD now? > > We've always used the max_lane_count from dpcd; has there been some > recent change that fixed usage of that? What I recall is one acer laptop > that advertised 4 lanes but had only wired up two of them. The only recentish change was your commit 9a10f401a401ca69c6537641c8fc0d6b57b5aee8 Author: Keith Packard Date: Wed Nov 2 13:03:47 2011 -0700 drm/i915: Use DPCD value for max DP lanes. The BIOS VBT value for an eDP panel has been shown to be incorrect on one machine, and we haven't found any machines where the DPCD value was wrong, so we'll use the DPCD value everywhere. We can but hope that no manufacturer lies in the DPCD. -Chris -- Chris Wilson, Intel Open Source Technology Centre