From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: disable drm agp support for !gen3 with kms enabled Date: Mon, 25 Jun 2012 16:18:32 +0100 Message-ID: <1340637552_67276@CP5-2952> References: <20120625072220.GB4708@phenom.ffwll.local> <1340632729-6048-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id F11429F01F for ; Mon, 25 Jun 2012 08:19:19 -0700 (PDT) In-Reply-To: <1340632729-6048-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Mon, 25 Jun 2012 15:58:49 +0200, Daniel Vetter wrote: > This is the quick&dirty way Dave Airlie suggested to workaround the > midlayer drm agp brain-damange. Note that i915_probe is only called > when the driver has ksm enabled, so no need to check for that. s/ksm/kms/ > > We also need to move the intel_agp_enabled check at the right place. > Note that the only thing this does is enforce the correct module load > order (by using a symbol from intel-agp.ko) to ensure that the fake > agp driver is ready before the drm core tries to set up the agp stuff. > > v2: Add a comment to explain why gen3 needs all this legacy fake agp > stuff - we've shipped an XvMC library with a kms-enabled ddx that > requires it (but only on gen3). > > v3: Make it clear that this is really a gen3 issue only in the > comment. Make it clear that this is only a gen3 issue in the comment. > Signed-Off-by: Daniel Vetter Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre