From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 3/5] drm/i915: don't return a spurious -EIO from intel_ring_begin Date: Mon, 25 Jun 2012 23:52:33 +0100 Message-ID: <1340664792_70515@CP5-2952> References: <1340548956-4097-1-git-send-email-daniel.vetter@ffwll.ch> <1340548956-4097-4-git-send-email-daniel.vetter@ffwll.ch> <1340656383_69674@CP5-2952> <20120625204903.GG4708@phenom.ffwll.local> <1340658438_69856@CP5-2952> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id D87659E754 for ; Mon, 25 Jun 2012 15:53:19 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Mon, 25 Jun 2012 23:48:01 +0200, Daniel Vetter wrote: > So essentially I still fail to see the upside of your proposed ductape > ... In either case I guess a walk to the reset button is inevitable > every once in a while ;-) A false positive for declaring a GPU wedged in a situation that should have never occurred in the first place is a recoverable and minor inconvenience compared to locking the display and possibly the system up. An alternative is to incorporate the deadlock detection into i915_mutex_lock_interruptible() and make it report -EIO if it waits longer than 10s, f.e., for the reset to complete. Then the only danger are the few paths that do not perform the error checking lock. -Chris -- Chris Wilson, Intel Open Source Technology Centre