From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 1/2] drm/i915: check whether we actually
	received an edid in detect_ddc
Date: Wed, 11 Jul 2012 11:44:36 +0100
Message-ID: <1342003482_250546@CP5-2952>
References: <1342000687_250108@CP5-2952>
	<1342002713-12628-1-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236])
	by gabe.freedesktop.org (Postfix) with ESMTP id 17EF8A0961
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 11 Jul 2012 03:44:46 -0700 (PDT)
In-Reply-To: <1342002713-12628-1-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, 11 Jul 2012 12:31:52 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Somehow detect_ddc manages to fall through all checks when we think
> that something responds on the ddc i2c address, but the edid read
> failed. Fix this up by explicitly checking for this case.
> 
> This fixes a regression on newer chips because since
> 
> commit aaa377302b2994fcc2c66741b47da33feb489dca
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date:   Sat Jun 16 15:30:32 2012 +0200
> 
>     drm/i915/crt: Do not rely upon the HPD presence pin
> 
> we use ddc detection also on hotplug capable platforms. And one of
> these reads all 0s for any i2c transaction if nothing is connected to
> the vga port.
> 
> v2: Implement Chris Wilson's review:
> - simplify logic, default to "nothing detected"
> - kill stale comment
> - BUG_ON(!crt->type != ANALOG)
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=51900
> Tested-by: Yang Guang <guang.a.yang@intel.com>
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

I'm happy with that, and thanks for the extra clarification in the debug
messages.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre