From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Jackson Subject: Re: [BUG] intel_drv.so fails to load Date: Wed, 18 Jul 2012 15:47:44 -0400 Message-ID: <1342640864.3590.71.camel@atropine> References: <5005C642.6030102@t-online.de> <1342556238_9775@CP5-2952> <1342557713_9832@CP5-2952> <5005D10E.4080101@t-online.de> <1342559830_9900@CP5-2952> <1342620128.3590.13.camel@atropine> <1342620454_12433@CP5-2952> <1342621766.3590.29.camel@atropine> <1342622195_12548@CP5-2952> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0537017768==" Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTP id 25BF59E738 for ; Wed, 18 Jul 2012 12:47:54 -0700 (PDT) In-Reply-To: <1342622195_12548@CP5-2952> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org --===============0537017768== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-uuBWnVqTNg8uH2kcIkbE" --=-uuBWnVqTNg8uH2kcIkbE Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2012-07-18 at 15:36 +0100, Chris Wilson wrote: > On Wed, 18 Jul 2012 10:29:26 -0400, Adam Jackson wrote: > > So those should resolve lazily, which means if you never call them they > > never _need_ to resolve. And this is how X drivers normally work, > > notice that libfb isn't loaded _before_ you load your driver but yet th= e > > driver loads. >=20 > They were being used by i810_dri.c, so i810 was busted. It just happened > to be that the first user to spot this was not using i810. Ennh. PreInit does: --- if (xf86ReturnOptValBool(pI810->Options, OPTION_NOACCEL, FALSE)) pI810->noAccel =3D TRUE; if (!pI810->noAccel) { if (!xf86LoadSubModule(scrn, "xaa")) { I810FreeRec(scrn); return FALSE; } } #ifdef HAVE_DRI1 pI810->directRenderingDisabled =3D !xf86ReturnOptValBool(pI810->Options, OPTION_DRI, TRUE); if (!pI810->directRenderingDisabled) { if (pI810->noAccel) { xf86DrvMsg(scrn->scrnIndex, X_WARNING, "DRI is disabled because it " "needs 2D acceleration.\n"); pI810->directRenderingDisabled=3DTRUE; } else if (scrn->depth!=3D16) { xf86DrvMsg(scrn->scrnIndex, X_WARNING, "DRI is disabled because it " "runs only at 16-bit depth.\n"); pI810->directRenderingDisabled=3DTRUE; } } #endif --- So we default to asking for XAA, and if it doesn't load (because you built without it) then neither will the driver; conversely, if XAA loads, DRI's use of XAA symbols would be safe. You'd have to have asked for Option "NoAccel" to hit that bug. It's not clear to me if, subsequent to your change, DRI would work with NoAccel. - ajax --=-uuBWnVqTNg8uH2kcIkbE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlAHEuAACgkQW4otUKDs0NO7MwCcCPI5nacfTvIbMJV1qA0P+duh oxMAnA6YyWe3mihlskDHPeYQvkaN01zY =+5aZ -----END PGP SIGNATURE----- --=-uuBWnVqTNg8uH2kcIkbE-- --===============0537017768== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0537017768==--