From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] [CFT] drm/i915: Only set the down rps limit when at the loweset frequency Date: Thu, 26 Jul 2012 10:37:42 +0100 Message-ID: <1343295465_1856@CP5-2952> References: <1343254184_355@CP5-2952> <1343294174-21811-1-git-send-email-daniel.vetter@ffwll.ch> <1343294631_1804@CP5-2952> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id E0C2A9E7B3 for ; Thu, 26 Jul 2012 02:37:55 -0700 (PDT) In-Reply-To: <1343294631_1804@CP5-2952> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org And then I remembered I was going to mention... I spent yesterday evening trying to tempt the fail back to IVB, to no avail. So I think the underlying cause was the sporadic read returning 0 which we promptly set to rplim with the original rmw sequence. Then we falsely continued to warn during intel_sanitize_pm() due to the same sporadic read failure. So I think we have painted all the elephants here. -Chris -- Chris Wilson, Intel Open Source Technology Centre