From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: Find bugs in i915 driver Date: Tue, 31 Jul 2012 08:57:36 +0100 Message-ID: <1343721467_20698@CP5-2952> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 769189E7CB for ; Tue, 31 Jul 2012 00:57:49 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: "Xu, Anhua" , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org On Tue, 31 Jul 2012 02:29:01 +0000, "Xu, Anhua" wrote: > Hi, I found some bugs in i915 driver when reviewing intel_display.c The parameter passed-in for function hdmi/adpa/lvds_pipe_enabled() are not coherent with functions' definition. > This is the patch. Patch looks good, you might want to mention that the regression was introduced with commit 1519b9956eb4b4180fa3f47c73341463cdcfaa37. Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre