From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] Fix build failure when passing --with-builderstring. Date: Sat, 04 Aug 2012 16:39:15 +0100 Message-ID: <1344094760_40449@CP5-2952> References: <1320704969-8530-1-git-send-email-kibi@debian.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id D41779E982 for ; Sat, 4 Aug 2012 08:39:33 -0700 (PDT) In-Reply-To: <1320704969-8530-1-git-send-email-kibi@debian.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Cyril Brulebois List-Id: intel-gfx@lists.freedesktop.org On Mon, 7 Nov 2011 23:29:29 +0100, Cyril Brulebois wrote: > If --with-builderstring="foo" is passed to configure (and sna enabled): > CC sna_driver.lo > src/sna/sna_driver.c: In function 'sna_init_scrn': > src/sna/sna_driver.c:1023:7: error: token ""foo"" is not valid in preprocessor expressions > > Fix the missing defined() around the BUILDER_DESCRIPTION variable. Apologies missed both the original and the ping, applied now. Many thanks, -Chris -- Chris Wilson, Intel Open Source Technology Centre