From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: dump the device info Date: Wed, 08 Aug 2012 22:41:14 +0100 Message-ID: <1344462074_60745@CP5-2952> References: <1344450604_60059@CP5-2952> <1344456111-31467-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id BE9F89F01E for ; Wed, 8 Aug 2012 14:41:20 -0700 (PDT) In-Reply-To: <1344456111-31467-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Wed, 8 Aug 2012 22:01:51 +0200, Daniel Vetter wrote: > Handy for lazy people like me, or when people forget to add the output > of lspci -nn. > > v2: Chris Wilson noticed that we have this duplicated already in the > i915_capabilites debugfs file. But there \n as separator looks better, > which would be a bit verbose in dmesg. Abuse the preprocessor to > extract this all. > > Signed-off-by: Daniel Vetter I like the placement of the cpp magic next to the struct, that should make it easier to update both at the same time. I think I'd prefer the struct first, magic cpp second. And given the alternatives, I think this is the cleanest way to minimise the code duplication. Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre