From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 4/4] drm/i915: Cleanup instdone state when idle Date: Tue, 14 Aug 2012 17:48:06 +0100 Message-ID: <1344962895_92970@CP5-2952> References: <1344922871-2248-1-git-send-email-ben@bwidawsk.net> <1344922871-2248-4-git-send-email-ben@bwidawsk.net> <1344929956_90118@CP5-2952> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id C37879E7B2 for ; Tue, 14 Aug 2012 09:48:20 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 14 Aug 2012 09:42:07 -0700, Ben Widawsky wrote: > On 2012-08-14 00:39, Chris Wilson wrote: > > On Mon, 13 Aug 2012 22:41:11 -0700, Ben Widawsky > > wrote: > >> The previous state is bogus when we've gone into idle. Actually > >> there > >> would be a known state of idle (ie. all units are done), but since > >> it > >> differs for every platform, we can just set 0, and let the hangcheck > >> progress as normal. > >> > >> References: https://bugs.freedesktop.org/show_bug.cgi?id=52429 > >> Tested-by: Guang A Yang > >> Signed-off-by: Ben Widawsky > > > > I think you have a point, but I don't think this should be just on > > idle. > > Everytime we kick off the hangcheck, we should not be comparing to > > stale > > state. > > Are you suggesting this is a patch which already exists somewhere? Not yet. :) Just that I agree with you that this a problem, and it is a bigger problem than first thought. -Chris -- Chris Wilson, Intel Open Source Technology Centre