From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH] drm/i915: Don't hardcode the number of
	pipes in the error state dump
Date: Wed, 15 Aug 2012 19:42:15 +0100
Message-ID: <1345056147_100284@CP5-2952>
References: <1345055005-23850-1-git-send-email-damien.lespiau@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236])
	by gabe.freedesktop.org (Postfix) with ESMTP id 5213C9EB38
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 15 Aug 2012 11:42:30 -0700 (PDT)
In-Reply-To: <1345055005-23850-1-git-send-email-damien.lespiau@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Damien Lespiau <damien.lespiau@gmail.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, 15 Aug 2012 19:23:25 +0100, Damien Lespiau <damien.lespiau@gmail.com> wrote:
> From: Damien Lespiau <damien.lespiau@intel.com>
> 
> New-ish devices have 3 pipes, so let's not just hardcode 2 but use the
> for_each_pipe() macro and make struct intel_display_error_state is big
> enough.
> 
> V2: Also add the number of pipes emitted (Chris Wilson)
> 
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

I guess next on your list will be adding some of the PCH register
states, along with a list of active encoders / connectors etc.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre