From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Jackson Subject: Re: [PATCH] drm/i915: use adjusted_mode instead of mode for checking the 6bpc force flag Date: Wed, 26 Sep 2012 11:50:36 -0400 Message-ID: <1348674636.4244.26.camel@atropine> References: <1348673271-23891-1-git-send-email-jani.nikula@intel.com> <1348674190-16908-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0989099411==" Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTP id DCD5B9E76B for ; Wed, 26 Sep 2012 08:50:39 -0700 (PDT) In-Reply-To: <1348674190-16908-1-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org --===============0989099411== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-dtpek+6g+7U6zuz1CYGd" --=-dtpek+6g+7U6zuz1CYGd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2012-09-26 at 18:43 +0300, Jani Nikula wrote: > The dithering introduced in >=20 > commit 3b5c78a35cf7511c15e09a9b0ffab290a42d9bcf > Author: Adam Jackson > Date: Tue Dec 13 15:41:00 2011 -0800 >=20 > drm/i915/dp: Dither down to 6bpc if it makes the mode fit >=20 > stores the INTEL_MODE_DP_FORCE_6BPC flag in the private_flags of the > adjusted mode, while i9xx_crtc_mode_set() and ironlake_crtc_mode_set() us= e > the original mode, without the flag, so it would never have any > effect. However, the BPC was clamped by VBT settings, making things work = by > coincidence, until that part was removed in >=20 > commit 4344b813f105a19f793f1fd93ad775b784648b95 > Author: Daniel Vetter > Date: Fri Aug 10 11:10:20 2012 +0200 >=20 > Use adjusted_mode instead of mode when checking for > INTEL_MODE_DP_FORCE_6BPC to make the flag have effect. >=20 > v2: Don't forget to fix this in i9xx_crtc_mode_set() also, pointed out by > Daniel both before and after sending the first patch. Reviewed-by: Adam Jackson - ajax --=-dtpek+6g+7U6zuz1CYGd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlBjJEwACgkQW4otUKDs0NM7MgCdE1taEWaaPhuQ6MEL3kMSnUii Sf8An28stLYW+P6ndlEP0esZBchgrXhn =ZQyU -----END PGP SIGNATURE----- --=-dtpek+6g+7U6zuz1CYGd-- --===============0989099411== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0989099411==--