Re: [PATCH 10/47] drm/i915: pipe and planes should be disabled on haswell_crtc_mode_set

Lespiau, Damien
2012-10-05T13:15:40Z

On Fri, Oct 5, 2012 at 1:53 PM, Paulo Zanoni <przanoni@gmail.com> wrote:
> 2012/10/4 Lespiau, Damien <damien.lespiau@intel.com>:
>> On Tue, Oct 2, 2012 at 9:51 PM, Paulo Zanoni <przanoni@gmail.com> wrote:
>>> @@ -5356,8 +5361,6 @@ static int haswell_crtc_mode_set(struct drm_crtc *crtc,
>>>
>>> haswell_set_pipeconf(crtc, adjusted_mode, dither);
>>>
>>> - intel_wait_for_vblank(dev, pipe);
>>> -
>>
>> I guess this hunk could go into a separate commit.
>
> My way of thinking is that since the pipe is disabled there's no
> reason to wait for vblank here.

Oh, sure I was just saying that it could deserve a separate commit
from the one adding the warning, but bikeshedding really.

--
Damien