Re: [PATCH 05/10] drm/i915: add proper CPU/PCH checks to crtc_mode_set functions

Lespiau, Damien
2012-10-10T13:52:02Z

On Fri, Oct 5, 2012 at 4:05 PM, Paulo Zanoni <przanoni@gmail.com> wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> On ironlake_crtc_mode_set, WARN if not using IBX or CPT.
>
> On haswell_crtc_mode_set, only run IBX/CPT code on IBX/CPT. I am still
> not sure whether IBX/CPT will be possible with a Haswell CPU, so leave
> the code there for now and put a WARN in case we spot it.
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

Hum, indeed, it'd be interesting to know if the HSW can have an
IBX/CPT PCH. Somehow I doubt it. We should definitely ask :). This
could potentially remove quite a bit of code. But for now:

Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

--
Damien