Re: [PATCH 02/47] drm/i915: enable and disable DDI_FUNC_CTL at the right time

Paulo Zanoni
2012-10-04T20:15:57Z

2012/10/3 Lespiau, Damien <damien.lespiau@intel.com>:
> On Tue, Oct 2, 2012 at 9:51 PM, Paulo Zanoni <przanoni@gmail.com> wrote:
>> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>>
>> And the right time is exactly after/before changing PIPE_CONF. See the
>> documentation about the mode set sequence.
>>
>> This code is not inside any encoder-specific callback because
>> DDI_FUNC_CTL is part of the pipe, so it is used by all encoders.
>
> Apart from the reordering of this patch with [PATCH 07/47] drm/i915:
> add haswell_crtc_mode_set,

This patch has nothing to do with patch 07. This patch touches
ironlake_crtc_{enable,disable}, not ironlake_crtc_mode_set. We did not
fork ironlake_crtc_{enable,disable} since the haswell-specific changes
are too small.

>
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

Thanks for the review :)

>
> --
> Damien

--
Paulo Zanoni