Re: [PATCH 09/14] drm/i915: fix DP AUX register definitions on Haswell

Lespiau, Damien
2012-10-18T13:57:43Z

On Mon, Oct 15, 2012 at 7:51 PM, Paulo Zanoni <przanoni@gmail.com> wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> The old rule that the AUX registers are just an offset (+4 and +10)
> from output_reg is not true anymore, since output_reg in on the CPU
> and some AUX regs are on the PCH.

Right, dp.output_reg is now DDI_BUF_CTL(port), note that _DATA is
still _AUX_CH_CTL + 4, so could keep that logic and just have switch
for DP_AUX_CH_CTL.

> +#define PCH_DPB_AUX_CH_CTL 0xe4110
> +#define PCH_DPC_AUX_CH_CTL 0xe4210
> +#define PCH_DPD_AUX_CH_CTL 0xe4310
> +
> +#define PCH_DPB_AUX_CH_DATA 0xe4114
> +#define PCH_DPC_AUX_CH_DATA 0xe4214
> +#define PCH_DPD_AUX_CH_DATA 0xe4314

Those defines are already there AFAICS:

http://cgit.freedesktop.org/~danvet/drm-intel/tree/drivers/gpu/drm/i915/i915_reg.h#n4017

--
Damien