From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH v2] flip_test: add wf-vblank test for expired sequence Date: Tue, 23 Oct 2012 14:57:37 +0300 Message-ID: <1350993457.7120.33.camel@localhost> References: <1350927609-14649-5-git-send-email-imre.deak@intel.com> <1350983272-26906-1-git-send-email-imre.deak@intel.com> <20121023104614.GL24005@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 0C08B9E7EB for ; Tue, 23 Oct 2012 04:57:46 -0700 (PDT) In-Reply-To: <20121023104614.GL24005@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 2012-10-23 at 12:46 +0200, Daniel Vetter wrote: > On Tue, Oct 23, 2012 at 12:07:52PM +0300, Imre Deak wrote: > > Signed-off-by: Imre Deak > > --- > > tests/flip_test.c | 58 ++++++++++++++++++++++++++++++++++++++++++++--------- > > 1 file changed, 48 insertions(+), 10 deletions(-) > > > > In v2: > > - Wait for the seq that just completed (current_seq) not last_seq - 1. > > - Do an equality check for ts and seq instead of >=. The previous issue > > didn't let us do this before. > > - Simplify the condition when we do an "expired sequence" check by only > > using the last flip event as a reference. > > Patch style comment: I prefer the changelog above the --- so that it's > included in the commit message. Safe obviously when the new patch has > abosulutely nothing to do with previous versions. Ok, noted. So far I thought the only benefit of the history here is to make the reviewer's life easier, but I agree it may be useful even later to understand the context. --Imre