Re: [PATCH 13/18] drm/i915: consolidate interrupt naming scheme

Damien Lespiau
2013-05-29T15:51:21Z

On Tue, May 28, 2013 at 11:50:46AM -0700, Ben Widawsky wrote:
> > > - if (gt_iir & (GT_GEN6_BLT_CS_ERROR_INTERRUPT |
> > > - GT_GEN6_BSD_CS_ERROR_INTERRUPT |
> > > - GT_RENDER_CS_ERROR_INTERRUPT)) {
> > > + if (gt_iir & (GT_BLT_CS_ERROR_INTERRUPT |
> > > + GT_BSD_CS_ERROR_INTERRUPT |
> > > + GT_RENDER_MASTER_ERROR_INTERRUPT)) {
> >
> > If we ware in the naming domain here, not sure why the CS master error
> > for render would have a different name than the others,
> > GT_RENDER_CS_ERROR_INTERRUPT looked good to me.
>
> I was just copying the docs. I presume on earlier gens, maybe it meant
> something else? It seems I accidently dropped the "CS" part though. I've
> added that back, and left the MASTER.
>
> "Render Command Parser Master Error"

They are all called $engine Command Parser Master Error, my point was
they should look alike (and I'd just drop the master, I think it's just
because it means an aggregate of the possible CS errors (2 at most as
far as I can see, privilege error and bad command).

--
Damien