From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Zanoni Subject: [PATCH 1/7] drm/i915: don't send DP idle pattern before normal pattern on HSW Date: Fri, 25 Jan 2013 16:59:10 -0200 Message-ID: <1359140356-4050-2-git-send-email-przanoni@gmail.com> References: <1359140356-4050-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-gg0-f174.google.com (mail-gg0-f174.google.com [209.85.161.174]) by gabe.freedesktop.org (Postfix) with ESMTP id 1BF3BE6E38 for ; Fri, 25 Jan 2013 10:59:51 -0800 (PST) Received: by mail-gg0-f174.google.com with SMTP id k5so109627ggd.33 for ; Fri, 25 Jan 2013 10:59:50 -0800 (PST) In-Reply-To: <1359140356-4050-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org From: Paulo Zanoni Previously I sent "drm/i915: don't read DP_TP_STATUS(PORT_A)", but after some more discussion I was told by a hardware engineer that we don't really need to send the idle patterns before the normal pattern in our current code: we only need this for a DP mode that we currently don't support. So for now, just kill the whole code. I've already asked for an update on the documentation, so at some point this code should match the docs. This solves "Timed out waiting for DP idle patterns" and "unclaimed register" messages on eDP. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_dp.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 51fd797..f2fa219 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -1785,16 +1785,7 @@ intel_dp_set_link_train(struct intel_dp *intel_dp, temp &= ~DP_TP_CTL_LINK_TRAIN_MASK; switch (dp_train_pat & DP_TRAINING_PATTERN_MASK) { case DP_TRAINING_PATTERN_DISABLE: - temp |= DP_TP_CTL_LINK_TRAIN_IDLE; - I915_WRITE(DP_TP_CTL(port), temp); - - if (wait_for((I915_READ(DP_TP_STATUS(port)) & - DP_TP_STATUS_IDLE_DONE), 1)) - DRM_ERROR("Timed out waiting for DP idle patterns\n"); - - temp &= ~DP_TP_CTL_LINK_TRAIN_MASK; temp |= DP_TP_CTL_LINK_TRAIN_NORMAL; - break; case DP_TRAINING_PATTERN_1: temp |= DP_TP_CTL_LINK_TRAIN_PAT1; -- 1.7.10.4