intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 5/7] drm/i915: check the power down well on assert_pipe()
Date: Fri, 25 Jan 2013 16:59:14 -0200	[thread overview]
Message-ID: <1359140356-4050-6-git-send-email-przanoni@gmail.com> (raw)
In-Reply-To: <1359140356-4050-1-git-send-email-przanoni@gmail.com>

From: Paulo Zanoni <paulo.r.zanoni@intel.com>

If the power well is disabled, we should not try to read its
registers, otherwise we'll get "unclaimed register" messages.

V2: Don't check whether the power well is enabled or not, just check
whether we asked it to be enabled or not: if we asked to disable the
power well, don't use the registers on it, even if it's still enabled.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 drivers/gpu/drm/i915/intel_display.c |   12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 456da5c..022c59d 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -1214,9 +1214,15 @@ void assert_pipe(struct drm_i915_private *dev_priv,
 	if (pipe == PIPE_A && dev_priv->quirks & QUIRK_PIPEA_FORCE)
 		state = true;
 
-	reg = PIPECONF(cpu_transcoder);
-	val = I915_READ(reg);
-	cur_state = !!(val & PIPECONF_ENABLE);
+	if (cpu_transcoder == TRANSCODER_EDP ||
+	    (I915_READ(HSW_PWR_WELL_DRIVER) & HSW_PWR_WELL_ENABLE)) {
+		reg = PIPECONF(cpu_transcoder);
+		val = I915_READ(reg);
+		cur_state = !!(val & PIPECONF_ENABLE);
+	} else {
+		cur_state = false;
+	}
+
 	WARN(cur_state != state,
 	     "pipe %c assertion failure (expected %s, current %s)\n",
 	     pipe_name(pipe), state_string(state), state_string(cur_state));
-- 
1.7.10.4

  parent reply	other threads:[~2013-01-25 18:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-25 18:59 [PATCH 0/7] Unclaimed registers and power well V2 Paulo Zanoni
2013-01-25 18:59 ` [PATCH 1/7] drm/i915: don't send DP idle pattern before normal pattern on HSW Paulo Zanoni
2013-01-26 16:53   ` Daniel Vetter
2013-01-25 18:59 ` [PATCH 2/7] drm/i915: fix intel_init_power_wells Paulo Zanoni
2013-01-26 16:54   ` Daniel Vetter
2013-01-25 18:59 ` [PATCH 3/7] drm/i915: dynamic Haswell display power well support Paulo Zanoni
2013-01-25 18:59 ` [PATCH 4/7] drm/i915: only disable enabled planes on intel_fb_restore_mode Paulo Zanoni
2013-01-25 18:59 ` Paulo Zanoni [this message]
2013-01-27 23:27   ` [PATCH 5/7] drm/i915: check the power down well on assert_pipe() Daniel Vetter
2013-01-25 18:59 ` [PATCH 6/7] drm/i915: turn on the power well before suspending Paulo Zanoni
2013-01-25 18:59 ` [PATCH 7/7] drm/i915: set TRANSCODER_EDP even earlier Paulo Zanoni
2013-01-26 16:57   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1359140356-4050-6-git-send-email-przanoni@gmail.com \
    --to=przanoni@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).