From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 0/7] Unclaimed register reporting V2
Date: Fri, 25 Jan 2013 18:57:35 -0200 [thread overview]
Message-ID: <1359147462-3902-1-git-send-email-przanoni@gmail.com> (raw)
From: Paulo Zanoni <paulo.r.zanoni@intel.com>
Hi
This is new version of 2 patches I sent last week. First we change how unclaimed
registers are currently reported by our driver and in the end we enable gen 7
error interrupts.
Here's what we do:
- Make the current code a little bit more organized
- Use FPGA_DBG instead of GEN7_ERR_INT for the polling code
- Initialize FPGA_DBG to clear one "unclaimed register" message
- Check unclaimed registers on I915_READ
- Replace the DRM_ERROR with WARNs
- Only print uncnlaimed registers if drm_debug is set
- Finally, print Gen 7 error interrupts
We had some discussion regarding these patches, and there is still no consensus
on what exactly we should do, so feel free to nack patches. Still, the patches
here are to some extent based on the comments I received (mainly from Ben,
Daniel and Chris), so I hope they're not too bad. Also, I really think that at
least the first 3 patches should be merged, and also some equivalent form of the
last patch should be merged.
Another thing I have to add: after patch 7 you may see a few dozen "unclaimed
register" messages when booting if you have the power well disabled. All these
messages go away if you blacklist snd_hda_intel. Still, I like to have messages
reminding me that something is wrong in some driver. And you'll only see those
messages if you have drm_debug, because of patch 0006.
Thanks,
Paulo
Paulo Zanoni (7):
drm/i915: create macros for the "unclaimed register" checks
drm/i915: use FPGA_DBG for the "unclaimed register" checks
drm/i915: clear the FPGA_DBG_RM_NOCLAIM bit at driver init
drm/i915: check for unclaimed registers on I915_READ too
drm/i915: WARN on unclaimed registers
drm/i915: only check for unclaimed registers if drm_debug
drm/i915: print Gen 7 error interrupts
drivers/gpu/drm/i915/i915_dma.c | 4 ++++
drivers/gpu/drm/i915/i915_drv.c | 26 ++++++++++++++++++--------
drivers/gpu/drm/i915/i915_irq.c | 28 +++++++++++++++++++++++++++-
drivers/gpu/drm/i915/i915_reg.h | 5 ++++-
4 files changed, 53 insertions(+), 10 deletions(-)
--
1.7.10.4
next reply other threads:[~2013-01-25 20:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 20:57 Paulo Zanoni [this message]
2013-01-25 20:57 ` [PATCH 1/7] drm/i915: create macros for the "unclaimed register" checks Paulo Zanoni
2013-01-26 1:02 ` Ben Widawsky
2013-01-28 20:17 ` Ben Widawsky
2013-01-25 20:57 ` [PATCH 2/7] drm/i915: use FPGA_DBG " Paulo Zanoni
2013-01-26 1:03 ` Ben Widawsky
2013-01-25 20:57 ` [PATCH 3/7] drm/i915: clear the FPGA_DBG_RM_NOCLAIM bit at driver init Paulo Zanoni
2013-01-26 1:05 ` Ben Widawsky
2013-01-29 19:02 ` [PATCH 3/3] " Paulo Zanoni
2013-01-25 20:57 ` [PATCH 4/7] drm/i915: check for unclaimed registers on I915_READ too Paulo Zanoni
2013-01-25 20:57 ` [PATCH 5/7] drm/i915: WARN on unclaimed registers Paulo Zanoni
2013-01-26 1:11 ` Ben Widawsky
2013-01-25 20:57 ` [PATCH 6/7] drm/i915: only check for unclaimed registers if drm_debug Paulo Zanoni
2013-01-25 20:57 ` [PATCH 7/7] drm/i915: print Gen 7 error interrupts Paulo Zanoni
2013-01-26 1:24 ` Ben Widawsky
2013-02-08 18:22 ` Paulo Zanoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359147462-3902-1-git-send-email-przanoni@gmail.com \
--to=przanoni@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).