From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Zanoni Subject: [PATCH 5/7] drm/i915: WARN on unclaimed registers Date: Fri, 25 Jan 2013 18:57:40 -0200 Message-ID: <1359147462-3902-6-git-send-email-przanoni@gmail.com> References: <1359147462-3902-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ye0-f176.google.com (mail-ye0-f176.google.com [209.85.213.176]) by gabe.freedesktop.org (Postfix) with ESMTP id B678DE6ED6 for ; Fri, 25 Jan 2013 12:58:07 -0800 (PST) Received: by mail-ye0-f176.google.com with SMTP id m1so134722yen.21 for ; Fri, 25 Jan 2013 12:58:06 -0800 (PST) In-Reply-To: <1359147462-3902-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org From: Paulo Zanoni While debugging these "unclaimed register" problems I concluded that having a backtrace is way much more useful than having the register address, since in a lot of cases the register address print on the message is not the register we're looking for. We must fix all the "unclaimed register" problems, so if dmesg gets too polluted it means we're too bugged. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/i915_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 422dfc6..bc0eb88 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -1227,14 +1227,14 @@ ilk_dummy_write(struct drm_i915_private *dev_priv) #define UNCLAIMED_REG_CLEAR(dev_priv, reg, op) \ if (IS_HASWELL(dev_priv->dev) && \ (I915_READ_NOTRACE(FPGA_DBG) & FPGA_DBG_RM_NOCLAIM)) { \ - DRM_ERROR("Unclaimed register before %x (%c)\n", reg, op); \ + WARN(1, "Unclaimed register before %x (%c)\n", reg, op); \ I915_WRITE_NOTRACE(FPGA_DBG, FPGA_DBG_RM_NOCLAIM); \ } #define UNCLAIMED_REG_CHECK(dev_priv, reg, op) \ if (IS_HASWELL(dev_priv->dev) && \ (I915_READ_NOTRACE(FPGA_DBG) & FPGA_DBG_RM_NOCLAIM)) { \ - DRM_ERROR("Unclaimed register %x (%c)\n", reg, op); \ + WARN(1, "Unclaimed register %x (%c)\n", reg, op); \ I915_WRITE_NOTRACE(FPGA_DBG, FPGA_DBG_RM_NOCLAIM); \ } -- 1.7.10.4