From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 6/7] drm/i915: only check for unclaimed registers if drm_debug
Date: Fri, 25 Jan 2013 18:57:41 -0200 [thread overview]
Message-ID: <1359147462-3902-7-git-send-email-przanoni@gmail.com> (raw)
In-Reply-To: <1359147462-3902-1-git-send-email-przanoni@gmail.com>
From: Paulo Zanoni <paulo.r.zanoni@intel.com>
This is a debug feature that may pollute dmesg and scare users, so
leave it for the debug mode only. We usually ask for bug reporters to
use the debug flags, so we will still have the opportunity to catch a
lot of errors on users' machines.
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
drivers/gpu/drm/i915/i915_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index bc0eb88..a401ec8 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1225,14 +1225,14 @@ ilk_dummy_write(struct drm_i915_private *dev_priv)
}
#define UNCLAIMED_REG_CLEAR(dev_priv, reg, op) \
- if (IS_HASWELL(dev_priv->dev) && \
+ if (drm_debug && IS_HASWELL(dev_priv->dev) && \
(I915_READ_NOTRACE(FPGA_DBG) & FPGA_DBG_RM_NOCLAIM)) { \
WARN(1, "Unclaimed register before %x (%c)\n", reg, op); \
I915_WRITE_NOTRACE(FPGA_DBG, FPGA_DBG_RM_NOCLAIM); \
}
#define UNCLAIMED_REG_CHECK(dev_priv, reg, op) \
- if (IS_HASWELL(dev_priv->dev) && \
+ if (drm_debug && IS_HASWELL(dev_priv->dev) && \
(I915_READ_NOTRACE(FPGA_DBG) & FPGA_DBG_RM_NOCLAIM)) { \
WARN(1, "Unclaimed register %x (%c)\n", reg, op); \
I915_WRITE_NOTRACE(FPGA_DBG, FPGA_DBG_RM_NOCLAIM); \
--
1.7.10.4
next prev parent reply other threads:[~2013-01-25 20:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 20:57 [PATCH 0/7] Unclaimed register reporting V2 Paulo Zanoni
2013-01-25 20:57 ` [PATCH 1/7] drm/i915: create macros for the "unclaimed register" checks Paulo Zanoni
2013-01-26 1:02 ` Ben Widawsky
2013-01-28 20:17 ` Ben Widawsky
2013-01-25 20:57 ` [PATCH 2/7] drm/i915: use FPGA_DBG " Paulo Zanoni
2013-01-26 1:03 ` Ben Widawsky
2013-01-25 20:57 ` [PATCH 3/7] drm/i915: clear the FPGA_DBG_RM_NOCLAIM bit at driver init Paulo Zanoni
2013-01-26 1:05 ` Ben Widawsky
2013-01-29 19:02 ` [PATCH 3/3] " Paulo Zanoni
2013-01-25 20:57 ` [PATCH 4/7] drm/i915: check for unclaimed registers on I915_READ too Paulo Zanoni
2013-01-25 20:57 ` [PATCH 5/7] drm/i915: WARN on unclaimed registers Paulo Zanoni
2013-01-26 1:11 ` Ben Widawsky
2013-01-25 20:57 ` Paulo Zanoni [this message]
2013-01-25 20:57 ` [PATCH 7/7] drm/i915: print Gen 7 error interrupts Paulo Zanoni
2013-01-26 1:24 ` Ben Widawsky
2013-02-08 18:22 ` Paulo Zanoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359147462-3902-7-git-send-email-przanoni@gmail.com \
--to=przanoni@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).