From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Zanoni Subject: [PATCH 6/7] drm/i915: only check for unclaimed registers if drm_debug Date: Fri, 25 Jan 2013 18:57:41 -0200 Message-ID: <1359147462-3902-7-git-send-email-przanoni@gmail.com> References: <1359147462-3902-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-yh0-f47.google.com (mail-yh0-f47.google.com [209.85.213.47]) by gabe.freedesktop.org (Postfix) with ESMTP id 3AB87E5FC6 for ; Fri, 25 Jan 2013 12:58:09 -0800 (PST) Received: by mail-yh0-f47.google.com with SMTP id w68so132858yhw.34 for ; Fri, 25 Jan 2013 12:58:08 -0800 (PST) In-Reply-To: <1359147462-3902-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org From: Paulo Zanoni This is a debug feature that may pollute dmesg and scare users, so leave it for the debug mode only. We usually ask for bug reporters to use the debug flags, so we will still have the opportunity to catch a lot of errors on users' machines. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/i915_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index bc0eb88..a401ec8 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -1225,14 +1225,14 @@ ilk_dummy_write(struct drm_i915_private *dev_priv) } #define UNCLAIMED_REG_CLEAR(dev_priv, reg, op) \ - if (IS_HASWELL(dev_priv->dev) && \ + if (drm_debug && IS_HASWELL(dev_priv->dev) && \ (I915_READ_NOTRACE(FPGA_DBG) & FPGA_DBG_RM_NOCLAIM)) { \ WARN(1, "Unclaimed register before %x (%c)\n", reg, op); \ I915_WRITE_NOTRACE(FPGA_DBG, FPGA_DBG_RM_NOCLAIM); \ } #define UNCLAIMED_REG_CHECK(dev_priv, reg, op) \ - if (IS_HASWELL(dev_priv->dev) && \ + if (drm_debug && IS_HASWELL(dev_priv->dev) && \ (I915_READ_NOTRACE(FPGA_DBG) & FPGA_DBG_RM_NOCLAIM)) { \ WARN(1, "Unclaimed register %x (%c)\n", reg, op); \ I915_WRITE_NOTRACE(FPGA_DBG, FPGA_DBG_RM_NOCLAIM); \ -- 1.7.10.4