From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 4/4] drm/i915: create compact dma scatter lists for gem objects Date: Sun, 10 Feb 2013 00:46:51 +0200 Message-ID: <1360450011.5252.8.camel@ideak-mobl> References: <1360423656-10816-1-git-send-email-imre.deak@intel.com> <1360423656-10816-5-git-send-email-imre.deak@intel.com> <20130209185934.GU5813@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130209185934.GU5813@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Rahul Sharma List-Id: intel-gfx@lists.freedesktop.org On Sat, 2013-02-09 at 19:59 +0100, Daniel Vetter wrote: > On Sat, Feb 09, 2013 at 05:27:36PM +0200, Imre Deak wrote: > > So far we created a sparse dma scatter list for gem objects, where each > > scatter list entry represented only a single page. In the future we'll > > have to handle compact scatter lists too where each entry can consist of > > multiple pages, for example for objects imported through PRIME. > > > > The previous patches have already fixed up all other places where the > > i915 driver _walked_ these lists. Here we have the corresponding fix to > > _create_ compact lists. It's not a performance or memory footprint > > improvement, but it helps to better exercise the new logic. > > > > Reference: http://www.spinics.net/lists/dri-devel/msg33917.html > > Signed-off-by: Imre Deak > > Just a quick question: Have you checked with printks or so that we indeed > create such coalesced sg entries every once in a while? Yes, quite often that was the case, so we at least are really testing the thing..