From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 0/4] FIFO underrun reporting v2
Date: Fri, 22 Feb 2013 17:05:27 -0300 [thread overview]
Message-ID: <1361563531-4653-1-git-send-email-przanoni@gmail.com> (raw)
From: Paulo Zanoni <paulo.r.zanoni@intel.com>
Hi
Here's a new series that tries to report FIFO underruns. The new implementation
is completely different from the old one, due to the reviews I received. Now we
don't just "ignore" the FIFO underrun interrupts when we receive them, we
effectively disable the interrupts (the downsides of this approach are
documented in the commit message of patch 2).
We will still see at most one of each error FIFO underrun message per mode set,
so this is not really going to flood dmesg. I tested this series on ILK, SNB and
HSW, and I am only seeing FIFO underruns on ILK when using 2 monitors
(LVDS+HDMI). I'll work on a patch to fix this message later (at least now we
know we have problems!).
It seems not everybody is in favor of adding the "poison" error message, so the
"print poison interrupts" patch comes _after_ the "print FIFO underruns". We can
discard the patch if we conclude we don't want it. I haven't seen the poison
message on any of my tests.
Thanks,
Paulo
Paulo Zanoni (4):
drm/i915: also disable south interrupts when handling them
drm/i915: report Gen5+ CPU and PCH FIFO underruns
drm/i915: print Gen5+ CPU/PCH poison interrupts
drm/i915: remove "inline" keyword from ironlake_disable_display_irq
drivers/gpu/drm/i915/i915_irq.c | 345 ++++++++++++++++++++++++++++++++--
drivers/gpu/drm/i915/i915_reg.h | 15 +-
drivers/gpu/drm/i915/intel_display.c | 17 +-
drivers/gpu/drm/i915/intel_drv.h | 10 +
4 files changed, 371 insertions(+), 16 deletions(-)
--
1.7.10.4
next reply other threads:[~2013-02-22 20:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 20:05 Paulo Zanoni [this message]
2013-02-22 20:05 ` [PATCH 1/4] drm/i915: also disable south interrupts when handling them Paulo Zanoni
2013-03-05 19:08 ` Daniel Vetter
2014-05-23 8:13 ` Daniel Vetter
2014-05-23 11:25 ` Paulo Zanoni
2014-05-23 11:43 ` Daniel Vetter
2013-02-22 20:05 ` [PATCH 2/4] drm/i915: report Gen5+ CPU and PCH FIFO underruns Paulo Zanoni
2013-03-28 13:24 ` Daniel Vetter
2013-04-12 20:05 ` Paulo Zanoni
2013-03-28 13:26 ` Daniel Vetter
2013-02-22 20:05 ` [PATCH 3/4] drm/i915: print Gen5+ CPU/PCH poison interrupts Paulo Zanoni
2013-03-28 13:25 ` Daniel Vetter
2013-02-22 20:05 ` [PATCH 4/4] drm/i915: remove "inline" keyword from ironlake_disable_display_irq Paulo Zanoni
2013-03-28 12:55 ` Daniel Vetter
2013-02-25 12:14 ` [PATCH 0/4] FIFO underrun reporting v2 Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361563531-4653-1-git-send-email-przanoni@gmail.com \
--to=przanoni@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox