From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Zanoni Subject: [PATCH 09/15] drm/i915: remove additional zerogin of VLV_IIR at postinstall Date: Tue, 23 Jul 2013 19:33:49 -0300 Message-ID: <1374618835-28120-10-git-send-email-przanoni@gmail.com> References: <1374618835-28120-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ye0-f180.google.com (mail-ye0-f180.google.com [209.85.213.180]) by gabe.freedesktop.org (Postfix) with ESMTP id 92169E66EA for ; Tue, 23 Jul 2013 15:35:02 -0700 (PDT) Received: by mail-ye0-f180.google.com with SMTP id q4so1105075yen.25 for ; Tue, 23 Jul 2013 15:35:02 -0700 (PDT) In-Reply-To: <1374618835-28120-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org From: Paulo Zanoni There is no comment explaining why it's needed and I don't see a reason for it to exist. Also, a few lines above we call INTEL_IRQ_REG_INIT and pass VLV_IIR, so we should print a WARN in case VLV_IIR is not zero at that point. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/i915_irq.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 6793b30..5ca50a0 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -2244,9 +2244,6 @@ static int valleyview_irq_postinstall(struct drm_device *dev) i915_enable_pipestat(dev_priv, 1, pipestat_enable); spin_unlock_irqrestore(&dev_priv->irq_lock, irqflags); - I915_WRITE(VLV_IIR, 0xffffffff); - I915_WRITE(VLV_IIR, 0xffffffff); - gen5_gt_irq_postinstall(dev); /* ack & enable invalid PTE error interrupts */ -- 1.8.1.2