From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Zanoni Subject: [PATCH 11/15] drm/i915: add INTEL_IRQ_REG_RESET16 Date: Tue, 23 Jul 2013 19:33:51 -0300 Message-ID: <1374618835-28120-12-git-send-email-przanoni@gmail.com> References: <1374618835-28120-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-yh0-f49.google.com (mail-yh0-f49.google.com [209.85.213.49]) by gabe.freedesktop.org (Postfix) with ESMTP id E627CE6121 for ; Tue, 23 Jul 2013 15:35:05 -0700 (PDT) Received: by mail-yh0-f49.google.com with SMTP id f64so1152962yha.8 for ; Tue, 23 Jul 2013 15:35:05 -0700 (PDT) In-Reply-To: <1374618835-28120-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org From: Paulo Zanoni Same thing as INTEL_IRQ_REG_RESET, but now on a separate patch, as requested by Ben. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/i915_irq.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 9684f1e..7588ad3 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -79,6 +79,15 @@ static const u32 hpd_status_i915[] = { /* i915 and valleyview are the same */ [HPD_PORT_D] = PORTD_HOTPLUG_INT_STATUS }; +#define INTEL_IRQ_REG_RESET16(type, do_iir) do { \ + I915_WRITE16(type##MR, 0xffff); \ + I915_WRITE16(type##ER, 0); \ + if (do_iir) \ + I915_WRITE16(type##IR, I915_READ16(type##IR)); \ + else \ + POSTING_READ16(type##ER); \ +} while (0) + #define INTEL_IRQ_REG_RESET(type) do { \ I915_WRITE(type##MR, 0xffffffff); \ I915_WRITE(type##ER, 0); \ @@ -2308,9 +2317,7 @@ static void i8xx_irq_preinstall(struct drm_device * dev) for_each_pipe(pipe) I915_WRITE(PIPESTAT(pipe), 0); - I915_WRITE16(IMR, 0xffff); - I915_WRITE16(IER, 0x0); - POSTING_READ16(IER); + INTEL_IRQ_REG_RESET16(I, false); } static int i8xx_irq_postinstall(struct drm_device *dev) @@ -2448,9 +2455,7 @@ static void i8xx_irq_uninstall(struct drm_device * dev) I915_WRITE(PIPESTAT(pipe), 0); I915_WRITE(PIPESTAT(pipe), I915_READ(PIPESTAT(pipe))); } - I915_WRITE16(IMR, 0xffff); - I915_WRITE16(IER, 0x0); - I915_WRITE16(IIR, I915_READ16(IIR)); + INTEL_IRQ_REG_RESET16(I, true); } static void i915_irq_preinstall(struct drm_device * dev) -- 1.8.1.2