From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Zanoni Subject: [PATCH 15/15] drm/i915: WARN if IIR is not zero at i8xx irq_postinstall Date: Tue, 23 Jul 2013 19:33:55 -0300 Message-ID: <1374618835-28120-16-git-send-email-przanoni@gmail.com> References: <1374618835-28120-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-yh0-f49.google.com (mail-yh0-f49.google.com [209.85.213.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 81616E6533 for ; Tue, 23 Jul 2013 15:35:12 -0700 (PDT) Received: by mail-yh0-f49.google.com with SMTP id f64so1161571yha.22 for ; Tue, 23 Jul 2013 15:35:12 -0700 (PDT) In-Reply-To: <1374618835-28120-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org From: Paulo Zanoni Same thing as the previous non-i8xx commit. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/i915_irq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 4f0bc26..8b12caa 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -100,8 +100,8 @@ static const u32 hpd_status_i915[] = { /* i915 and valleyview are the same */ } while (0) #define INTEL_IRQ_REG_INIT16(type, do_iir, ier_val, imr_val) do { \ - if (do_iir) \ - I915_WRITE16(type##IR, I915_READ16(type##IR)); \ + WARN(I915_READ16(type##IR) != 0, "Register 0x%x is not 0\n", \ + type##IR); \ I915_WRITE16(type##MR, (imr_val)); \ I915_WRITE16(type##ER, (ier_val)); \ POSTING_READ16(type##ER); \ -- 1.8.1.2