intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 2/8] drm/i915: don't disable/reenable IVB error interrupts when not needed
Date: Mon, 29 Jul 2013 17:48:21 -0300	[thread overview]
Message-ID: <1375130907-4054-3-git-send-email-przanoni@gmail.com> (raw)
In-Reply-To: <1375130907-4054-1-git-send-email-przanoni@gmail.com>

From: Paulo Zanoni <paulo.r.zanoni@intel.com>

If the error interrupts are already disabled, don't disable and
reenable them. This is going to be needed when we're in PC8+, where
all the interrupts are disabled so we won't risk re-enabling
DE_ERR_INT_IVB.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 drivers/gpu/drm/i915/i915_irq.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 6a1c207..2b0690a 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -1309,6 +1309,7 @@ static irqreturn_t ironlake_irq_handler(int irq, void *arg)
 	drm_i915_private_t *dev_priv = (drm_i915_private_t *) dev->dev_private;
 	u32 de_iir, gt_iir, de_ier, sde_ier = 0;
 	irqreturn_t ret = IRQ_NONE;
+	bool err_int_reenable = false;
 
 	atomic_inc(&dev_priv->irq_received);
 
@@ -1337,7 +1338,10 @@ static irqreturn_t ironlake_irq_handler(int irq, void *arg)
 	 * handler. */
 	if (IS_HASWELL(dev)) {
 		spin_lock(&dev_priv->irq_lock);
-		ironlake_disable_display_irq(dev_priv, DE_ERR_INT_IVB);
+		if (!(I915_READ(DEIMR) & DE_ERR_INT_IVB)) {
+			ironlake_disable_display_irq(dev_priv, DE_ERR_INT_IVB);
+			err_int_reenable = true;
+		}
 		spin_unlock(&dev_priv->irq_lock);
 	}
 
@@ -1373,7 +1377,7 @@ static irqreturn_t ironlake_irq_handler(int irq, void *arg)
 		}
 	}
 
-	if (IS_HASWELL(dev)) {
+	if (err_int_reenable) {
 		spin_lock(&dev_priv->irq_lock);
 		if (ivb_can_enable_err_int(dev))
 			ironlake_enable_display_irq(dev_priv, DE_ERR_INT_IVB);
-- 
1.8.1.2

  parent reply	other threads:[~2013-07-29 20:48 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-29 20:48 [PATCH 0/8] Allow Package C8+ Paulo Zanoni
2013-07-29 20:48 ` [PATCH 1/8] drm/i915: add the FCLK case to intel_ddi_get_cdclk_freq Paulo Zanoni
2013-07-29 20:48 ` Paulo Zanoni [this message]
2013-07-30  9:46   ` [PATCH 2/8] drm/i915: don't disable/reenable IVB error interrupts when not needed Chris Wilson
2013-08-01 17:16     ` Paulo Zanoni
2013-07-29 20:48 ` [PATCH 3/8] drm/i915: allow package C8+ states on Haswell (disabled) Paulo Zanoni
2013-07-29 21:42   ` Chris Wilson
2013-07-31 14:24     ` Paulo Zanoni
2013-07-31 15:01       ` Chris Wilson
2013-07-31 16:47         ` Paulo Zanoni
2013-07-29 23:11   ` Chris Wilson
2013-07-29 20:48 ` [PATCH 4/8] drm/i915: avoid waking up from PC8 on DP AUX operations Paulo Zanoni
2013-07-30  9:40   ` Chris Wilson
2013-07-31 14:31     ` Paulo Zanoni
2013-07-31 14:45       ` Chris Wilson
2013-07-29 20:48 ` [PATCH 5/8] drm/i915: avoid waking up from PC8 on GMBUS operations Paulo Zanoni
2013-07-30  9:30   ` Chris Wilson
2013-08-05  6:07     ` Daniel Vetter
2013-08-05 13:17       ` Paulo Zanoni
2013-07-29 20:48 ` [PATCH 6/8] drm/i915: silence message about the DDI buffers Paulo Zanoni
2013-07-29 20:48 ` [PATCH 7/8] drm/i915: add i915_pc8_status debugfs file Paulo Zanoni
2013-07-29 20:48 ` [PATCH 8/8] drm/i915: allow Package C8+ by default Paulo Zanoni
2013-07-30  9:25   ` Chris Wilson
2013-07-29 20:53 ` [PATCH i-g-t] tests: add pc8 Paulo Zanoni
2013-08-05  6:05   ` Daniel Vetter
2013-08-05 13:42     ` Paulo Zanoni
2013-08-05 15:35       ` Daniel Vetter
2013-08-06 19:33         ` Paulo Zanoni
2013-08-06 20:11           ` Daniel Vetter
2013-08-06 20:18             ` Daniel Vetter
2013-08-06 20:43             ` Paulo Zanoni
2013-08-13 21:48               ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375130907-4054-3-git-send-email-przanoni@gmail.com \
    --to=przanoni@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).