From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [igt PATCH 4/4] tests: add kms_setmode Date: Fri, 16 Aug 2013 14:23:44 +0300 Message-ID: <1376652224.2576.22.camel@intelbox> References: <1375703126-19323-1-git-send-email-imre.deak@intel.com> <1375703126-19323-5-git-send-email-imre.deak@intel.com> <20130806092356.GU22035@phenom.ffwll.local> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1584224892==" Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 3710EE6345 for ; Fri, 16 Aug 2013 04:23:46 -0700 (PDT) In-Reply-To: <20130806092356.GU22035@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1584224892== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-PPzNUUSSYuk9qVYvPD1x" --=-PPzNUUSSYuk9qVYvPD1x Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2013-08-06 at 11:23 +0200, Daniel Vetter wrote: > On Mon, Aug 05, 2013 at 02:45:26PM +0300, Imre Deak wrote: > > Iterate through all valid/invalid crtc/connector combinations. At the > > moment only clone configurations are tested as the single output cases > > are tested already by testdisplay. Also from combinations where all > > connectors are on the same crtc (clone-single-crtc) only those are > > tested that are invalid, as I haven't found any machine that supports > > these (have to be GT2 with dvo and vga output). > >=20 > > For configurations with one crtc per connector the FBs are per-crtc atm= . > >=20 > > Signed-off-by: Imre Deak >=20 > lgtm. Please push as soon as we've figured out what to do with patch 3. >=20 > I wonder whether we shouldn't change our DP code a bit and force the > port into normal mode (with some conservative link training values) even > when link training fails. Contrary to fdi links I think the pixels would > still flow and so would allow us to exercise more codepaths. But that's > for another time I guess. Yes, for testing purposes allowing the pipe to be on even on disconnected DP would be nice. The same for other disconnected connectors worked out quite well for me w/o all the required displays. > Depending upon how the kms_ tests shape up we might want to extract a bit > more code from here, but again we can do that later. Yep, agreed as a next step. --Imre --=-PPzNUUSSYuk9qVYvPD1x Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQEcBAABAgAGBQJSDgvAAAoJEORIIAnNuWDFeiUH/iEhZEgDNHYMAtjd710PGDSG idEm51IA3rCWGGJPwT+4S5dMb3VsOknbQZFuoQAY0gzyf0LhjrLWuZ8NJZa5+XaJ N5F484ZRmW1zKBYF+WSWFocY6I171yez4w4IMn9d8KJaSxLvwv764Dn8rFQy3JF/ eU0rYlqsOsBRe/Md8CoKogjgy6u4hSnSlXzZMiI0+qluiDQZezKxRZtxlbGmK+Oq fep5vF2vZcYefH488/ABS+OKc/oNZs9VjN21Wq0ysoP7yB0h0TEFHanvH7xUyqgT iz80Qy2PnynTEsuvieCTsJDjeIzKNmePyXyiiHQ4FIWcaEUmE9u4d9DfxXwUpdI= =+3f6 -----END PGP SIGNATURE----- --=-PPzNUUSSYuk9qVYvPD1x-- --===============1584224892== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1584224892==--