From: Ben Widawsky <benjamin.widawsky@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: [PATCH 3/3] drm/i915/vma: Remove VMA from exec_list on destroy
Date: Mon, 19 Aug 2013 23:14:15 -0700 [thread overview]
Message-ID: <1376979255-17887-3-git-send-email-benjamin.widawsky@intel.com> (raw)
In-Reply-To: <1376979255-17887-1-git-send-email-benjamin.widawsky@intel.com>
In order to avoid confusion, and corruption as observed (in code review)
by Chris - remove the VMA from the exec_list at destroy.
Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
---
drivers/gpu/drm/i915/i915_gem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 6d2d7df..9f03f5d 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -4160,6 +4160,7 @@ void i915_gem_vma_destroy(struct i915_vma *vma)
return;
WARN_ON(vma->node.allocated);
+ list_del(&vma->exec_list);
list_del(&vma->vma_link);
kfree(vma);
}
--
1.8.3.4
next prev parent reply other threads:[~2013-08-20 6:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 6:14 [PATCH 1/3] drm/i915/vma: Add a busy flag; means don't destroy Ben Widawsky
2013-08-20 6:14 ` [PATCH 2/3] drm/i915/vma: Mark vmas busy during execbuf lookup Ben Widawsky
2013-08-20 6:14 ` Ben Widawsky [this message]
2013-08-20 8:01 ` [PATCH 3/3] drm/i915/vma: Remove VMA from exec_list on destroy Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376979255-17887-3-git-send-email-benjamin.widawsky@intel.com \
--to=benjamin.widawsky@intel.com \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox