public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Ben Widawsky <benjamin.widawsky@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>,
	Ben Widawsky <benjamin.widawsky@intel.com>
Subject: [PATCH 4/7] intel_gtt: Use function to get the physical address
Date: Sun,  1 Sep 2013 12:51:23 -0700	[thread overview]
Message-ID: <1378065086-28705-4-git-send-email-benjamin.widawsky@intel.com> (raw)
In-Reply-To: <1378065086-28705-1-git-send-email-benjamin.widawsky@intel.com>

The GTT PTEs that the tool is trying to compare is really about
addresses, and not the PTE itself. To accomplish this, make which
calculates the physical address we actually want.

This commit itself doesn't change any functionality; just the wording in
the code.

Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
---
 tools/intel_gtt.c | 26 +++++++++++++++-----------
 1 file changed, 15 insertions(+), 11 deletions(-)

diff --git a/tools/intel_gtt.c b/tools/intel_gtt.c
index 7885610..32a6618 100644
--- a/tools/intel_gtt.c
+++ b/tools/intel_gtt.c
@@ -34,16 +34,20 @@
 
 #include "intel_gpu_tools.h"
 
-#define INGTT(offset) (*(volatile uint32_t *)(gtt + (offset) / (KB(4) / 4)))
-
 #define KB(x) ((x) * 1024)
 #define MB(x) ((x) * 1024 * 1024)
+unsigned char *gtt;
+
+#define INGTT(offset) (*(volatile uint32_t *)(gtt + (offset) / (KB(4) / 4)))
+static uint64_t get_phys(uint32_t pt_offset)
+{
+	return INGTT(pt_offset);
+}
 
 int main(int argc, char **argv)
 {
 	struct pci_device *pci_dev;
 	int start, aper_size;
-	unsigned char *gtt;
 	uint32_t devid;
 	int flag[] = {
 		PCI_DEV_MAP_FLAG_WRITE_COMBINE,
@@ -90,15 +94,15 @@ int main(int argc, char **argv)
 	aper_size = pci_dev->regions[2].size;
 
 	for (start = 0; start < aper_size; start += KB(4)) {
-		uint32_t start_pte = INGTT(start);
+		uint32_t start_phys = INGTT(start);
 		uint32_t end;
 		int constant_length = 0;
 		int linear_length = 0;
 
 		/* Check if it's a linear sequence */
 		for (end = start + KB(4); end < aper_size; end += KB(4)) {
-			uint32_t end_pte = INGTT(end);
-			if (end_pte == start_pte + (end - start))
+			uint32_t end_phys = INGTT(end);
+			if (end_phys == start_phys + (end - start))
 				linear_length++;
 			else
 				break;
@@ -107,27 +111,27 @@ int main(int argc, char **argv)
 			printf("0x%08x - 0x%08x: linear from "
 			       "0x%08x to 0x%08x\n",
 			       start, end - KB(4),
-			       start_pte, start_pte + (end - start) - KB(4));
+			       start_phys, start_phys + (end - start) - KB(4));
 			start = end - KB(4);
 			continue;
 		}
 
 		/* Check if it's a constant sequence */
 		for (end = start + KB(4); end < aper_size; end += KB(4)) {
-			uint32_t end_pte = INGTT(end);
-			if (end_pte == start_pte)
+			uint32_t end_phys = INGTT(end);
+			if (end_phys == start_phys)
 				constant_length++;
 			else
 				break;
 		}
 		if (constant_length > 0) {
 			printf("0x%08x - 0x%08x: constant 0x%08x\n",
-			       start, end - KB(4), start_pte);
+			       start, end - KB(4), start_phys);
 			start = end - KB(4);
 			continue;
 		}
 
-		printf("0x%08x: 0x%08x\n", start, start_pte);
+		printf("0x%08x: 0x%08x\n", start, start_phys);
 	}
 
 	return 0;
-- 
1.8.4

  parent reply	other threads:[~2013-09-01 19:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-01 19:51 [PATCH 1/7] intel_reg_dumper: Silence GCC for uninitialized clock Ben Widawsky
2013-09-01 19:51 ` [PATCH 2/7] gem_vmap_blits: Demote warning to note Ben Widawsky
2013-09-01 19:51 ` [PATCH 3/7] tools/Makefile.am: use -Werror Ben Widawsky
2013-09-01 19:51 ` Ben Widawsky [this message]
2013-09-01 19:51 ` [PATCH 5/7] intel_gtt: Properly support gen6+ GTT PTEs Ben Widawsky
2013-09-02  7:14   ` Daniel Vetter
2013-09-01 19:51 ` [PATCH 6/7] intel_gtt: Support HSW PTEs Ben Widawsky
2013-09-01 19:51 ` [PATCH 7/7] intel_gtt: Raw PTE dumper mode Ben Widawsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378065086-28705-4-git-send-email-benjamin.widawsky@intel.com \
    --to=benjamin.widawsky@intel.com \
    --cc=ben@bwidawsk.net \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox