Re: [PATCH 10/16] intel_l3_parity: Assert all GEN7+ support

Ben Widawsky
2013-09-17T23:53:04Z

On Mon, Sep 16, 2013 at 06:18:28PM +0000, Bell, Bryan J wrote:
> L3 dynamic parity is not supported on VLV. Please add the check for VLV.
>
> I can send you the email thread, if needed.
>
> --Thanks
> Bryan

More importantly, we need to fix this in the kernel too. Thanks for
catching this.

>
> -----Original Message-----
> From: Ben Widawsky [mailto:benjamin.widawsky@intel.com]
> Sent: Thursday, September 12, 2013 10:29 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Venkatesh, Vishnu; Bell, Bryan J; Widawsky, Benjamin; Ben Widawsky
> Subject: [PATCH 10/16] intel_l3_parity: Assert all GEN7+ support
>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> ---
> tools/intel_l3_parity.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/intel_l3_parity.c b/tools/intel_l3_parity.c index 970dcd6..a3d268b 100644
> --- a/tools/intel_l3_parity.c
> +++ b/tools/intel_l3_parity.c
> @@ -120,7 +120,7 @@ int main(int argc, char *argv[])
> assert(ret != -1);
>
> fd = open(path, O_RDWR);
> - if (fd == -1 && IS_IVYBRIDGE(devid)) {
> + if (fd == -1 && intel_gen(devid) > 6) {
> perror("Opening sysfs");
> exit(EXIT_FAILURE);
> } else if (fd == -1)
> --
> 1.8.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Ben Widawsky, Intel Open Source Technology Center