public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Chon Ming Lee <chon.ming.lee@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 1/2] drm/i915: Send a DPIO cmnreset during driver load or system resume.
Date: Fri, 13 Sep 2013 14:39:20 +0800	[thread overview]
Message-ID: <1379054361-26440-2-git-send-email-chon.ming.lee@intel.com> (raw)
In-Reply-To: <1379054361-26440-1-git-send-email-chon.ming.lee@intel.com>

Without the DPIO cmnreset, the PLL fail to lock.  This should have
done by BIOS.

v2: Move this to intel_uncore_sanitize to allow it to get call during
resume path. (Daniel)

Signed-off-by: Chon Ming Lee <chon.ming.lee@intel.com>
---
 drivers/gpu/drm/i915/intel_uncore.c |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
index 8649f1c..b1f53f3 100644
--- a/drivers/gpu/drm/i915/intel_uncore.c
+++ b/drivers/gpu/drm/i915/intel_uncore.c
@@ -276,10 +276,25 @@ static void intel_uncore_forcewake_reset(struct drm_device *dev)
 
 void intel_uncore_sanitize(struct drm_device *dev)
 {
+	struct drm_i915_private *dev_priv = dev->dev_private;
+	u32 reg_val;
+
 	intel_uncore_forcewake_reset(dev);
 
 	/* BIOS often leaves RC6 enabled, but disable it for hw init */
 	intel_disable_gt_powersave(dev);
+
+	/* Trigger DPIO CMN RESET, require especially in BIOS less
+	 * system
+	 */
+	if (IS_VALLEYVIEW(dev)) {
+		reg_val = I915_READ(DPIO_CTL);
+		if (!(reg_val & 0x1)) {
+			I915_WRITE(DPIO_CTL, 0x0);
+			I915_WRITE(DPIO_CTL, 0x1);
+			POSTING_READ(DPIO_CTL);
+		}
+	}
 }
 
 /*
-- 
1.7.7.6

  reply	other threads:[~2013-09-13  6:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <[PATCH] drm/i915: Enable VLV to work in BIOS-less system>
2013-09-13  6:39 ` [PATCH 0/2] Enable VLV to work in BIOS-less system Chon Ming Lee
2013-09-13  6:39   ` Chon Ming Lee [this message]
2013-09-13 11:43     ` [PATCH 1/2] drm/i915: Send a DPIO cmnreset during driver load or system resume Ville Syrjälä
2013-09-24  9:46     ` Chon Ming Lee
2013-09-13  6:39   ` [PATCH 2/2] drm/i915: Program GMBUS Frequency based on the CDCLK Chon Ming Lee
2013-09-13 11:23     ` Ville Syrjälä
2013-09-13 12:48       ` Daniel Vetter
2013-09-24  9:47     ` [PATCH 2/2] drm/i915: Program GMBUS Frequency based on the CDCLK for VLV Chon Ming Lee
2013-09-24 12:54       ` Ville Syrjälä
2013-09-24 13:18         ` Lee, Chon Ming
2013-09-24 13:45           ` Ville Syrjälä
2013-09-27  7:31       ` Chon Ming Lee
2013-09-27 10:07         ` Ville Syrjälä
2013-09-27 19:31           ` Daniel Vetter
     [not found] <[PATCH 1/2] drm/i915: Send a DPIO cmnreset during driver load or system resume.>
2013-09-24  7:14 ` [PATCH 1/2] drm/i915: Send a DPIO cmnreset during driver load or system resume Chon Ming Lee
2013-09-24 15:18   ` Ville Syrjälä
2013-09-24 23:14     ` Lee, Chon Ming
2013-09-25  7:25       ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1379054361-26440-2-git-send-email-chon.ming.lee@intel.com \
    --to=chon.ming.lee@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox