From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 1/4] drm/i915: WARN in case PIPECONF is already enabled
Date: Thu, 19 Sep 2013 17:07:26 -0300 [thread overview]
Message-ID: <1379621249-1816-2-git-send-email-przanoni@gmail.com> (raw)
In-Reply-To: <1379621249-1816-1-git-send-email-przanoni@gmail.com>
From: Paulo Zanoni <paulo.r.zanoni@intel.com>
After the modeset rework this really shouldn't be happening, so
transform it into a WARN. A stuck pipe is a bad signal and is one of
the things that can lead to full machine hangs.
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 8fd13ab..5f1399d 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -1737,7 +1737,7 @@ static void intel_enable_pipe(struct drm_i915_private *dev_priv, enum pipe pipe,
reg = PIPECONF(cpu_transcoder);
val = I915_READ(reg);
- if (val & PIPECONF_ENABLE)
+ if (WARN_ON(val & PIPECONF_ENABLE))
return;
I915_WRITE(reg, val | PIPECONF_ENABLE);
--
1.8.3.1
next prev parent reply other threads:[~2013-09-19 20:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 20:07 [PATCH 0/4] Remove useless vblank waits on Haswell Paulo Zanoni
2013-09-19 20:07 ` Paulo Zanoni [this message]
2013-09-20 6:36 ` [PATCH 1/4] drm/i915: WARN in case PIPECONF is already enabled Ville Syrjälä
2013-09-20 19:51 ` Paulo Zanoni
2013-09-19 20:07 ` [PATCH 2/4] drm/i915: don't intel_wait_for_vblank inside intel_enable_pipe Paulo Zanoni
2013-09-19 20:07 ` [PATCH 3/4] drm/i915: remove useless vblank wait form haswell_crtc_enable Paulo Zanoni
2013-09-19 20:07 ` [PATCH 4/4] drm/i915: skip useless vblank wait on Haswell audio sequence Paulo Zanoni
2013-09-19 20:28 ` Chris Wilson
2013-09-20 8:17 ` Daniel Vetter
2013-09-20 19:22 ` Paulo Zanoni
2013-09-22 10:37 ` Lin, Mengdong
2013-10-10 18:33 ` Paulo Zanoni
2013-10-10 19:07 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379621249-1816-2-git-send-email-przanoni@gmail.com \
--to=przanoni@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox