public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 3/4] drm/i915: remove useless vblank wait form haswell_crtc_enable
Date: Thu, 19 Sep 2013 17:07:28 -0300	[thread overview]
Message-ID: <1379621249-1816-4-git-send-email-przanoni@gmail.com> (raw)
In-Reply-To: <1379621249-1816-1-git-send-email-przanoni@gmail.com>

From: Paulo Zanoni <paulo.r.zanoni@intel.com>

This function is called in a point where the pipe is not really
running (the fact that PIPECONF is enabled doesn't mean that the pipe
is actually running), so we pay the full 50ms timeout. Also, I
couldn't find a reason why this is needed, so just skip it.

I do have to notice we still have other vblank waits at later points
of the mode set sequence, and at least some of them make sense.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 2f546f7..69e8bb6 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -3509,7 +3509,6 @@ static void haswell_crtc_enable(struct drm_crtc *crtc)
 	intel_update_watermarks(crtc);
 	intel_enable_pipe(dev_priv, pipe,
 			  intel_crtc->config.has_pch_encoder, false);
-	intel_wait_for_vblank(dev, pipe);
 
 	if (intel_crtc->config.has_pch_encoder)
 		lpt_pch_enable(crtc);
-- 
1.8.3.1

  parent reply	other threads:[~2013-09-19 20:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-19 20:07 [PATCH 0/4] Remove useless vblank waits on Haswell Paulo Zanoni
2013-09-19 20:07 ` [PATCH 1/4] drm/i915: WARN in case PIPECONF is already enabled Paulo Zanoni
2013-09-20  6:36   ` Ville Syrjälä
2013-09-20 19:51     ` Paulo Zanoni
2013-09-19 20:07 ` [PATCH 2/4] drm/i915: don't intel_wait_for_vblank inside intel_enable_pipe Paulo Zanoni
2013-09-19 20:07 ` Paulo Zanoni [this message]
2013-09-19 20:07 ` [PATCH 4/4] drm/i915: skip useless vblank wait on Haswell audio sequence Paulo Zanoni
2013-09-19 20:28   ` Chris Wilson
2013-09-20  8:17   ` Daniel Vetter
2013-09-20 19:22     ` Paulo Zanoni
2013-09-22 10:37     ` Lin, Mengdong
2013-10-10 18:33       ` Paulo Zanoni
2013-10-10 19:07         ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1379621249-1816-4-git-send-email-przanoni@gmail.com \
    --to=przanoni@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox