From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Zanoni Subject: [PATCH 3/4] drm/i915: remove useless vblank wait form haswell_crtc_enable Date: Thu, 19 Sep 2013 17:07:28 -0300 Message-ID: <1379621249-1816-4-git-send-email-przanoni@gmail.com> References: <1379621249-1816-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ye0-f178.google.com (mail-ye0-f178.google.com [209.85.213.178]) by gabe.freedesktop.org (Postfix) with ESMTP id D911CE7B52 for ; Thu, 19 Sep 2013 13:07:51 -0700 (PDT) Received: by mail-ye0-f178.google.com with SMTP id m5so3572770yen.23 for ; Thu, 19 Sep 2013 13:07:51 -0700 (PDT) In-Reply-To: <1379621249-1816-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org From: Paulo Zanoni This function is called in a point where the pipe is not really running (the fact that PIPECONF is enabled doesn't mean that the pipe is actually running), so we pay the full 50ms timeout. Also, I couldn't find a reason why this is needed, so just skip it. I do have to notice we still have other vblank waits at later points of the mode set sequence, and at least some of them make sense. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_display.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 2f546f7..69e8bb6 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -3509,7 +3509,6 @@ static void haswell_crtc_enable(struct drm_crtc *crtc) intel_update_watermarks(crtc); intel_enable_pipe(dev_priv, pipe, intel_crtc->config.has_pch_encoder, false); - intel_wait_for_vblank(dev, pipe); if (intel_crtc->config.has_pch_encoder) lpt_pch_enable(crtc); -- 1.8.3.1