From: Ben Widawsky <benjamin.widawsky@intel.com>
To: Intel GFX <intel-gfx@lists.freedesktop.org>
Cc: Eero Tamminen <eero.t.tamminen@intel.com>,
Ben Widawsky <ben@bwidawsk.net>,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: [PATCH] [RFT] drm/i915: Don't waste our paultry cache on a context object
Date: Fri, 20 Sep 2013 08:05:02 -0700 [thread overview]
Message-ID: <1379689502-7462-1-git-send-email-benjamin.widawsky@intel.com> (raw)
Context save and restore is by definition a slow process, however it is
also an infrequent process. Don't try to optimize the save restore at
the cost of any of our precious cache space. Contexts begin to get quite
large on HSW and beyond.
At least for benchmarks people seem to care about, there is almost
always only 1 context running, which means I don't expect this to do any
harm. For benchmarks with many contexts, there could be performance
degradation - but I have a sneaking suspicion the HW will do some fancy
magic to speak up context save & restores anyway.
CC: Chris Wilson <chris@chris-wilson.co.uk>
CC: Eero Tamminen <eero.t.tamminen@intel.com>
Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
---
drivers/gpu/drm/i915/i915_gem_context.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c
index 26c3fcc..593be55 100644
--- a/drivers/gpu/drm/i915/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/i915_gem_context.c
@@ -153,13 +153,10 @@ create_hw_context(struct drm_device *dev,
return ERR_PTR(-ENOMEM);
}
- if (INTEL_INFO(dev)->gen >= 7) {
- ret = i915_gem_object_set_cache_level(ctx->obj,
- I915_CACHE_L3_LLC);
- /* Failure shouldn't ever happen this early */
- if (WARN_ON(ret))
- goto err_out;
- }
+ ret = i915_gem_object_set_cache_level(ctx->obj, I915_CACHE_NONE);
+ /* Failure shouldn't ever happen this early */
+ if (WARN_ON(ret))
+ goto err_out;
/* The ring associated with the context object is handled by the normal
* object tracking code. We give an initial ring value simple to pass an
--
1.8.4
next reply other threads:[~2013-09-20 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 15:05 Ben Widawsky [this message]
2013-09-20 15:12 ` [PATCH] [RFT] drm/i915: Don't waste our paultry cache on a context object Chris Wilson
2013-09-20 15:24 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379689502-7462-1-git-send-email-benjamin.widawsky@intel.com \
--to=benjamin.widawsky@intel.com \
--cc=ben@bwidawsk.net \
--cc=eero.t.tamminen@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox