From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [RFC] Runtime display PM for VLV/BYT Date: Wed, 16 Oct 2013 17:45:47 +0300 Message-ID: <1381934747.22425.23.camel@intelbox> References: <1381792069-27800-1-git-send-email-jbarnes@virtuousgeek.org> <20131015080606.GM13047@intel.com> <1381839371.26119.12.camel@intelbox> <20131015092311.1dadcf35@jbarnes-desktop> <1381860919.3361.37.camel@ideak-mobl> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1832416684==" Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 3A0BCE80AA for ; Wed, 16 Oct 2013 07:45:50 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx , Paulo R Zanoni List-Id: intel-gfx@lists.freedesktop.org --===============1832416684== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-WM8R1BGWgYXzSQdCs3TH" --=-WM8R1BGWgYXzSQdCs3TH Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2013-10-16 at 00:09 +0200, Daniel Vetter wrote: > On Tue, Oct 15, 2013 at 8:15 PM, Imre Deak wrote: > > Related to this: I made intel_encoder_get_hw_state() only check if the > > power well is on and return false if it's not to indicate that the > > encoder is off. I also thought of doing the same as you and take a ref > > instead, not sure what's the right way. Maybe doing the readout only if > > the power is on, but also making sure we have a reference in this case? > > So with a new helper we'd have in intel_encoder_get_hw_state(): >=20 > I think the approach we've quickly discussed in today's call is > probably simplest: We grab a temporary reference to all the display > power wells around all the dpms/modeset functions and ignore any power > well checks on top of that. The hw will (well, should) be in the power > on default state, so nothing should magically turn on if we don't want > that. Ok, I'm fine with this too for now, later it can be improved if needed.=20 I added a new POWER_DOMAIN_INIT for keeping all power wells on through driver init->first modeset and suspend->first modeset, that could be used for this purpose too. --Imre --=-WM8R1BGWgYXzSQdCs3TH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQEcBAABAgAGBQJSXqabAAoJEORIIAnNuWDFQhoH/i0IxQc+aDa/TP5cMaGVtu8W p+0CJZTfCQNtQEL5dkx6torjxBv6F5fIxXdT+4dcupiYjJcbBm0h54lMy+GKv4Xm h4v4OVGV0wcNyqqbvcqDA2Wcw/iK12w0qGJxpGcqWvJlnZUaGot2fi6cPlu8bW2q 6x4gm0X/QqjlIXp8WtFfzZHFkjS2ReZo2/uobJxf9UnUQqhidMD+r8dT3Q4dSQLW w0Os26FHzMq7McXs2ab4+UW7ryvWM9myGctcVRi/kyJe06c/+sNI8vwTK6a6JNm2 XHd1A0kh/RAVTUCQtGCIeiS8nB5FddEWu6fnTjKV2Aj98mHCdm5YC7TccMX8fT8= =feED -----END PGP SIGNATURE----- --=-WM8R1BGWgYXzSQdCs3TH-- --===============1832416684== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1832416684==--