From mboxrd@z Thu Jan  1 00:00:00 1970
From: Imre Deak <imre.deak@intel.com>
Subject: Re: [PATCH v3 3/4] drm/i915: remove device field from
 struct power_well
Date: Mon, 28 Oct 2013 20:31:08 +0200
Message-ID: <1382985068.2664.3.camel@ideak-mobl>
References: <1382464076-5030-1-git-send-email-imre.deak@intel.com>
	<1382711810-25881-1-git-send-email-imre.deak@intel.com>
	<1382711810-25881-4-git-send-email-imre.deak@intel.com>
	<CA+gsUGQaAnAALPqR-sPzx9uA59K5a_NQTYQ+Aev78S17wUfJLQ@mail.gmail.com>
	<20131027193024.GL18189@phenom.ffwll.local>
	<CA+gsUGSYY3LF37hoGPdkxyaeSaRyqPeRX+f0jedH0s+hMYvNeA@mail.gmail.com>
Reply-To: imre.deak@intel.com
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
	by gabe.freedesktop.org (Postfix) with ESMTP id 0E783E661E
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 28 Oct 2013 11:31:25 -0700 (PDT)
In-Reply-To: <CA+gsUGSYY3LF37hoGPdkxyaeSaRyqPeRX+f0jedH0s+hMYvNeA@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, 2013-10-28 at 15:41 -0200, Paulo Zanoni wrote:
> 2013/10/27 Daniel Vetter <daniel@ffwll.ch>:
> > On Fri, Oct 25, 2013 at 05:50:18PM -0200, Paulo Zanoni wrote:
> >> 2013/10/25 Imre Deak <imre.deak@intel.com>:
> >> > The only real need for this field was in
> >> > i915_{request,release}_power_well, but there we can get at it by a
> >> > container_of magic. Also since in the future we'll have multiple power
> >> > wells each with its own power_well struct it makes sense to remove the
> >> > field from there where it'd be just redundancy.
> >> >
> >> > Suggested-by: Paulo Zanoni <paulo.zanoni@intel.com>
> >>
> >> My original idea was to just move it from i915_power_well to
> >> i915_power_domains, so hsw_pwr (which is the new external static
> >> thing) would still have a pointer to our driver. This way we wouldn't
> >> need the container_of magic. But your solution works too, and saves
> >> 4/8 bytes :)
> >>
> >> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >
> > First 3 patches merged, thanks.
> 
> I just realized that at some point we accidentally killed the
> i915.disable_power_well option... I see the i915_disable_power_well
> variable is not being used anywhere. Imre, can you please investigate
> that?

Yep, that got removed by mistake in

commit 6efdf354ddb186c6604d1692075421e8d2c740e9
Author: Imre Deak <imre.deak@intel.com>
Date:   Wed Oct 16 17:25:52 2013 +0300

    drm/i915: enable only the needed power domains during modeset

I'll follow up with a fix.

--Imre