From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Xiang, Haihao" Subject: Re: [RFC 00/22] Gen7 batch buffer command parser Date: Wed, 27 Nov 2013 16:54:31 +0800 Message-ID: <1385542471.6449.43.camel@xhh-ivb32> References: <1385484699-51596-1-git-send-email-bradley.d.volkin@intel.com> <20131126193538.GR27344@phenom.ffwll.local> <20131126202414.GA52952@vpg-ubuntu-bdvolkin> <1385515952.2037.25.camel@genxdev-ykzhao.sh.intel.com> <20131127081028.GU27344@phenom.ffwll.local> <1385540608.6449.36.camel@xhh-ivb32> <1385541731.6449.39.camel@xhh-ivb32> <20131127084757.GV27344@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 2B15DFA426 for ; Wed, 27 Nov 2013 00:52:41 -0800 (PST) In-Reply-To: <20131127084757.GV27344@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Daniel Vetter Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org On Wed, 2013-11-27 at 09:47 +0100, Daniel Vetter wrote: > On Wed, Nov 27, 2013 at 04:42:11PM +0800, Xiang, Haihao wrote: > > On Wed, 2013-11-27 at 09:31 +0100, Daniel Vetter wrote: > > > On Wed, Nov 27, 2013 at 9:23 AM, Xiang, Haihao wrote: > > > >> So are these 2nd level batches constructed by the gpu in some cases? That > > > >> would be fairly horribly to take into account with the batch checker ... > > > > > > > > It is *not* the 2nd level batch buffer (bit 22 isn't set). Only batch > > > > buffer chain is used. > > > > > > That's not really the hard part for the command checker, the important > > > question is whether the gpu generates these batches or whether they're > > > constructed by the cpu. > > > > Yes, some batches are generated by GPU, either by EU shaders or by BSD > > unit (batch buffer for MC on ILK). > > So is ilk the only platform which does that? The command checker is only > for gen7+ (and maybe gen6). No. In libva some batches are generated by BSD unit on ILK. on Gen6+, some batches are constructed by GPU shader. > -Daniel