From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: [PATCH 3/6] drm/i915: Downgrade pipe state mismatches to DRM_DEBUG_KMS Date: Mon, 2 Dec 2013 11:26:08 -0200 Message-ID: <1385990771-3877-4-git-send-email-rodrigo.vivi@gmail.com> References: <1385990771-3877-1-git-send-email-rodrigo.vivi@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-qe0-f47.google.com (mail-qe0-f47.google.com [209.85.128.47]) by gabe.freedesktop.org (Postfix) with ESMTP id 7A16DFAC9A for ; Mon, 2 Dec 2013 05:26:40 -0800 (PST) Received: by mail-qe0-f47.google.com with SMTP id t7so13043967qeb.20 for ; Mon, 02 Dec 2013 05:26:40 -0800 (PST) In-Reply-To: <1385990771-3877-1-git-send-email-rodrigo.vivi@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org From: Adam Jackson This is, by far, the most common kernel retrace in i915 I'm seeing: https://retrace.fedoraproject.org/faf/problems/1346879/ There's not enough information in the backtrace to know if something actually went wrong or if this is just an assertion failure, so it's pretty useless. Downgrade this to DRM_DEBUG_KMS so we can still see it if we want it. Signed-off-by: Adam Jackson Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 035588a..a403611 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -9463,7 +9463,7 @@ check_crtc_state(struct drm_device *dev) if (active && !intel_pipe_config_compare(dev, &crtc->config, &pipe_config)) { - WARN(1, "pipe state doesn't match!\n"); + DRM_DEBUG_KMS("pipe state doesn't match!\n"); intel_dump_pipe_config(crtc, &pipe_config, "[hw state]"); intel_dump_pipe_config(crtc, &crtc->config, -- 1.8.3.1