From mboxrd@z Thu Jan 1 00:00:00 1970 From: tvrtko.ursulin@linux.intel.com Subject: [PATCH] build: Make sure asserts are enabled for tests Date: Tue, 3 Dec 2013 15:09:57 +0000 Message-ID: <1386083397-27634-1-git-send-email-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 4DF29FB41D for ; Tue, 3 Dec 2013 07:10:16 -0800 (PST) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org From: Tvrtko Ursulin Tests depend on assertions being enabled since they can, and do, contain actual test steps. They are also mandatory for ensuring sane test case behaviour. Signed-off-by: Tvrtko Ursulin --- lib/check-ndebug.h | 3 +++ tests/Android.mk | 2 +- tests/Makefile.am | 1 + 3 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 lib/check-ndebug.h diff --git a/lib/check-ndebug.h b/lib/check-ndebug.h new file mode 100644 index 0000000..68a6ec4 --- /dev/null +++ b/lib/check-ndebug.h @@ -0,0 +1,3 @@ +#ifdef NDEBUG +#error "Testsuite needs its asserts!" +#endif diff --git a/tests/Android.mk b/tests/Android.mk index 1bd3d21..ec64acd 100644 --- a/tests/Android.mk +++ b/tests/Android.mk @@ -40,7 +40,7 @@ define add_test $(LIBPCIACCESS_PATH)/include LOCAL_CFLAGS += -DHAVE_STRUCT_SYSINFO_TOTALRAM - LOCAL_CFLAGS += -DANDROID + LOCAL_CFLAGS += -DANDROID -UNDEBUG -include "check-ndebug.h" LOCAL_CFLAGS += -std=c99 # FIXME: drop once Bionic correctly annotates "noreturn" on pthread_exit LOCAL_CFLAGS += -Wno-error=return-type diff --git a/tests/Makefile.am b/tests/Makefile.am index 8e293f7..b8cddd5 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -23,6 +23,7 @@ CLEANFILES = $(EXTRA_PROGRAMS) AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) \ -I$(srcdir)/.. \ -I$(srcdir)/../lib \ + -include "check-ndebug.h" \ -DIGT_DATADIR=\""$(abs_srcdir)"\" \ $(NULL) -- 1.8.4.3