From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: [PATCH 1/2] Revert "lib/drmtest: ducttape over fork race" Date: Tue, 3 Dec 2013 16:44:54 +0000 Message-ID: <1386089095-9966-2-git-send-email-tvrtko.ursulin@linux.intel.com> References: <1386089095-9966-1-git-send-email-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 30E02FB48E for ; Tue, 3 Dec 2013 08:45:23 -0800 (PST) In-Reply-To: <1386089095-9966-1-git-send-email-tvrtko.ursulin@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org From: Tvrtko Ursulin This reverts commit a031a1bf93b828585e7147f06145fc5030814547. Signed-off-by: Tvrtko Ursulin Conflicts: lib/drmtest.c --- lib/drmtest.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/lib/drmtest.c b/lib/drmtest.c index 94fa686..dcacd3b 100644 --- a/lib/drmtest.c +++ b/lib/drmtest.c @@ -1127,7 +1127,6 @@ static void fork_helper_exit_handler(int sig) bool __igt_fork_helper(struct igt_helper_process *proc) { pid_t pid; - sighandler_t oldsig; int id; assert(!proc->running); @@ -1138,13 +1137,6 @@ bool __igt_fork_helper(struct igt_helper_process *proc) igt_install_exit_handler(fork_helper_exit_handler); - /* - * XXX: There's a race between fork and the subsequent kill in - * igt_stop_signal_helper if we don't ovewrite the SIGQUIT handler. Note - * that inserting sufficient amounts of printf or other delays makes - * this unnecessary. - */ - oldsig = signal(SIGQUIT, SIG_DFL); switch (pid = fork()) { case -1: igt_assert(0); @@ -1155,8 +1147,6 @@ bool __igt_fork_helper(struct igt_helper_process *proc) return true; default: - signal(SIGQUIT, oldsig); - proc->running = true; proc->pid = pid; proc->id = id; -- 1.8.4.3